Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(gnss_poser): add autoware prefix to gnss_poser #8323

Merged
merged 6 commits into from
Aug 29, 2024
Merged

chore(gnss_poser): add autoware prefix to gnss_poser #8323

merged 6 commits into from
Aug 29, 2024

Conversation

TaikiYamada4
Copy link
Contributor

@TaikiYamada4 TaikiYamada4 commented Aug 1, 2024 •
edited
Loading

Description

Following the movement of adding autoware_ prefix to package names, this PR adds autoware prefix to gnss_poser.

Related links

Since this PR strongly relates to sensor launching systems, this PR must be merged together with the following PRs.

How was this PR tested?

Confirmed that gnss_poser launches and works as normal in the rosbag replay simulation.

Notes for reviewers

Since this PR strongly relates to sensor launching systems, this PR must be merged together with the following PRs.

Interface changes

None.

Effects on system behavior

None.

@github-actions github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) component:sensing Data acquisition from sensors, drivers, preprocessing. (auto-assigned) type:ci Continuous Integration (CI) processes and testing. (auto-assigned) labels Aug 1, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 1, 2024 •
edited
Loading

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

This was referenced Aug 2, 2024
Merged
Merged
Merged
@TaikiYamada4 TaikiYamada4 marked this pull request as ready for review August 2, 2024 02:33
@TaikiYamada4 TaikiYamada4 self-assigned this Aug 2, 2024
@TaikiYamada4 TaikiYamada4 added run:deploy-docs Mark for deploy-docs action generation. (used-by-ci) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) labels Aug 2, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 2, 2024

Documentation URL: https://autowarefoundation.github.io/autoware.universe/pr-8323/
Modified URLs:

@codecov Codecov
Copy link

codecov bot commented Aug 2, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 23.91%. Comparing base (d08dcfe) to head (0ed39a3).
Report is 27 commits behind head on main.

Files with missing lines Patch % Lines
...ensing/autoware_gnss_poser/src/gnss_poser_core.cpp 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #8323      +/-   ##
==========================================
- Coverage   24.11%   23.91%   -0.20%     
==========================================
  Files        1399     1384      -15     
  Lines      102426   101527     -899     
  Branches    38920    38558     -362     
==========================================
- Hits        24696    24285     -411     
+ Misses      75252    74806     -446     
+ Partials     2478     2436      -42
Flag Coverage Δ *Carryforward flag
differential 0.00% <0.00%> (?)
total 23.97% <ø> (-0.14%) ⬇️ Carriedforward from 049adf9

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TaikiYamada4 TaikiYamada4 mentioned this pull request Aug 2, 2024
Merged
4 tasks
@kyoichi-sugahara
Copy link
Contributor

kyoichi-sugahara commented Aug 3, 2024 •
edited
Loading

@TaikiYamada4
As described in the following comment,

Since this PR strongly relates to sensor launching systems, this PR must be merged together with the following PRs.

Multiple PRs need to be merged simultaneously.
However, due to this PR being unintentionally merged, it appears that errors are occurring during rosdep execution.

SakodaShintaro
SakodaShintaro approved these changes Aug 5, 2024
View reviewed changes
Copy link
Contributor

@SakodaShintaro SakodaShintaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have confirmed that logging_simulator works well.

And I checked

  • Directory Name

    • Add autoware_ as a prefix to the directory name.

  • packages.xml

    • Add autoware_ to the name element.

  • CMakeLists.txt

    • Change the project name to autoware_***.
    • Add autoware:: to PLUGIN.
    • (Optional) Stop using ${PROJECT_NAME}.

  • Header Files (.hpp)

    • Start #ifndef guards with AUTOWARE__.
    • Add autoware:: to namespace.
    • Change the comment after namespace definition.

  • Source Files (.cpp)

    • Add autoware:: to namespace.
    • Change the comment after namespace definition.
    • Add autoware:: inside RCLCPP_COMPONENTS_REGISTER_NODE.

  • Launch Files

    • Add autoware_ before find-pkg-share.
    • Change node pkg="<pkgname>" to autoware_<pkgname>.

  • CODEOWNERS

    • Add autoware_ to the relevant package.
    • Arrange entries alphabetically within the same component.

  • Include

    • Add autoware folder as necessary and update include statements accordingly.
    • Check for impacts on other packages.

  • Verification Points

    • Search find-pkg-share in autoware
    • Check README file (especially json schema)
    • Pay attention to complex cases like sensor_launch as seen in gnss_poser

esteve
esteve approved these changes Aug 6, 2024
View reviewed changes
Copy link
Contributor

@esteve esteve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TaikiYamada4 LGTM, thanks!

@esteve esteve mentioned this pull request Aug 6, 2024
Open
@TaikiYamada4 TaikiYamada4 mentioned this pull request Aug 9, 2024
Merged
@github-actions github-actions bot added the component:evaluator Evaluation tools for planning, localization etc. (auto-assigned) label Aug 20, 2024
@TaikiYamada4 TaikiYamada4 marked this pull request as draft August 20, 2024 02:07
@TaikiYamada4
Copy link
Contributor Author

Sorry for my mistake on git operation, I will fix this soon.

@TaikiYamada4 TaikiYamada4 force-pushed the chore/gnss_poser/add_autoware_prefix branch from 79adeff to a52640d Compare August 20, 2024 02:15
@github-actions github-actions bot removed component:perception Advanced sensor data processing and environment understanding. (auto-assigned) component:localization Vehicle's position determination in its environment. (auto-assigned) component:planning Route planning, decision-making, and navigation. (auto-assigned) component:control Vehicle control algorithms and mechanisms. (auto-assigned) component:system System design and integration. (auto-assigned) component:map Map creation, storage, and loading. (auto-assigned) component:vehicle Vehicle-specific implementations, drivers, packages. (auto-assigned) component:launch Launch files, scripts and initialization tools. (auto-assigned) component:common Common packages from the autoware-common repository. (auto-assigned) component:simulation Virtual environment setups and simulations. (auto-assigned) component:evaluator Evaluation tools for planning, localization etc. (auto-assigned) labels Aug 20, 2024
@TaikiYamada4 TaikiYamada4 force-pushed the chore/gnss_poser/add_autoware_prefix branch from a52640d to 049adf9 Compare August 20, 2024 02:47
@TaikiYamada4 TaikiYamada4 marked this pull request as ready for review August 20, 2024 04:39
@TaikiYamada4 TaikiYamada4 mentioned this pull request Aug 21, 2024
Merged
4 tasks
@TaikiYamada4 TaikiYamada4 merged commit 769d6c8 into autowarefoundation:main Aug 29, 2024
31 checks passed
@TaikiYamada4 TaikiYamada4 deleted the chore/gnss_poser/add_autoware_prefix branch August 29, 2024 07:53
@SakodaShintaro SakodaShintaro mentioned this pull request Aug 29, 2024
Merged
a-maumau pushed a commit to a-maumau/autoware.universe that referenced this pull request Sep 2, 2024
@TaikiYamada4 @pre-commit-ci
@vividf @a-maumau
chore(gnss_poser): add autoware prefix to gnss_poser (autowarefoundat…
a66bcc6 
…ion#8323)

* add "autoware" prefix to gnss_poser

Signed-off-by: TaikiYamada4 <[email protected]>

* Fixed typos and left overs

Signed-off-by: TaikiYamada4 <[email protected]>

* Fixed directory mistake

Signed-off-by: TaikiYamada4 <[email protected]>

* style(pre-commit): autofix

* Removed gnss_poser line from CODEOWNERS

Signed-off-by: TaikiYamada4 <[email protected]>

---------

Signed-off-by: TaikiYamada4 <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Yi-Hsiang Fang (Vivid) <[email protected]>
ktro2828 pushed a commit to ktro2828/autoware.universe that referenced this pull request Sep 18, 2024
@TaikiYamada4 @pre-commit-ci
@vividf @ktro2828
chore(gnss_poser): add autoware prefix to gnss_poser (autowarefoundat…
7a26e4b 
…ion#8323)

* add "autoware" prefix to gnss_poser

Signed-off-by: TaikiYamada4 <[email protected]>

* Fixed typos and left overs

Signed-off-by: TaikiYamada4 <[email protected]>

* Fixed directory mistake

Signed-off-by: TaikiYamada4 <[email protected]>

* style(pre-commit): autofix

* Removed gnss_poser line from CODEOWNERS

Signed-off-by: TaikiYamada4 <[email protected]>

---------

Signed-off-by: TaikiYamada4 <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Yi-Hsiang Fang (Vivid) <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SakodaShintaro SakodaShintaro SakodaShintaro approved these changes

@esteve esteve esteve approved these changes

@anhnv3991 anhnv3991 Awaiting requested review from anhnv3991 anhnv3991 is a code owner

@KYabuuchi KYabuuchi Awaiting requested review from KYabuuchi KYabuuchi is a code owner

@Motsu-san Motsu-san Awaiting requested review from Motsu-san Motsu-san is a code owner

@RyuYamamoto RyuYamamoto Awaiting requested review from RyuYamamoto RyuYamamoto is a code owner

@YamatoAndo YamatoAndo Awaiting requested review from YamatoAndo YamatoAndo is a code owner

@taikitanaka3 taikitanaka3 Awaiting requested review from taikitanaka3

@N-Eiki N-Eiki Awaiting requested review from N-Eiki

@1222-takeshi 1222-takeshi Awaiting requested review from 1222-takeshi

@tkimura4 tkimura4 Awaiting requested review from tkimura4

@ito-san ito-san Awaiting requested review from ito-san

@TetsuKawa TetsuKawa Awaiting requested review from TetsuKawa

@isamu-takagi isamu-takagi Awaiting requested review from isamu-takagi

@mitsudome-r mitsudome-r Awaiting requested review from mitsudome-r

@yukkysaito yukkysaito Awaiting requested review from yukkysaito

@soblin soblin Awaiting requested review from soblin

@maxime-clem maxime-clem Awaiting requested review from maxime-clem

@TakaHoribe TakaHoribe Awaiting requested review from TakaHoribe

@zulfaqar-azmi-t4 zulfaqar-azmi-t4 Awaiting requested review from zulfaqar-azmi-t4

@knzo25 knzo25 Awaiting requested review from knzo25

@amc-nu amc-nu Awaiting requested review from amc-nu

@badai-nguyen badai-nguyen Awaiting requested review from badai-nguyen

@drwnz drwnz Awaiting requested review from drwnz

@kyoichi-sugahara kyoichi-sugahara Awaiting requested review from kyoichi-sugahara

@meliketanrikulu meliketanrikulu Awaiting requested review from meliketanrikulu

@miursh miursh Awaiting requested review from miursh

@vividf vividf Awaiting requested review from vividf

@YoshiRi YoshiRi Awaiting requested review from YoshiRi

@shmpwk shmpwk Awaiting requested review from shmpwk

@takayuki5168 takayuki5168 Awaiting requested review from takayuki5168

@kosuke55 kosuke55 Awaiting requested review from kosuke55

@satoshi-ota satoshi-ota Awaiting requested review from satoshi-ota

@rej55 rej55 Awaiting requested review from rej55

@mehmetdogru mehmetdogru Awaiting requested review from mehmetdogru

@mkuri mkuri Awaiting requested review from mkuri

@TomohitoAndo TomohitoAndo Awaiting requested review from TomohitoAndo

@ahmeddesokyebrahim ahmeddesokyebrahim Awaiting requested review from ahmeddesokyebrahim

@go-sakayori go-sakayori Awaiting requested review from go-sakayori

@danielsanchezaran danielsanchezaran Awaiting requested review from danielsanchezaran

@mkquda mkquda Awaiting requested review from mkquda

@brkay54 brkay54 Awaiting requested review from brkay54

@beyzanurkaya beyzanurkaya Awaiting requested review from beyzanurkaya

@tzhong518 tzhong518 Awaiting requested review from tzhong518

@technolojin technolojin Awaiting requested review from technolojin

@dan-dnn dan-dnn Awaiting requested review from dan-dnn

@manato manato Awaiting requested review from manato

@ktro2828 ktro2828 Awaiting requested review from ktro2828

@kaancolak kaancolak Awaiting requested review from kaancolak

@scepter914 scepter914 Awaiting requested review from scepter914

@kminoda kminoda Awaiting requested review from kminoda

@Shin-kyoto Shin-kyoto Awaiting requested review from Shin-kyoto

@IshitaTakeshi IshitaTakeshi Awaiting requested review from IshitaTakeshi

@KeisukeShima KeisukeShima Awaiting requested review from KeisukeShima

@djargot djargot Awaiting requested review from djargot

Assignees

@TaikiYamada4 TaikiYamada4

Labels
component:sensing Data acquisition from sensors, drivers, preprocessing. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) run:deploy-docs Mark for deploy-docs action generation. (used-by-ci) tag:require-cuda-build-and-test type:ci Continuous Integration (CI) processes and testing. (auto-assigned) type:documentation Creating or refining documentation. (auto-assigned)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@TaikiYamada4 @kyoichi-sugahara @esteve @SakodaShintaro @vividf